test: use the current triage VM slug, not the deprecated win10 one - #317
Merged
Conversation
The sandbox tests dispatched 'triage' with vm_slug='win10-build-15063' at 8 call sites. That is not a valid triage VM: the server rewrites any slug containing 'win10' to 'windows11-21h2-x64' for backward compatibility and logs an ERROR each time it does. Every e2e run therefore carried 8 server-side ERROR lines that were entirely self-inflicted. Send the real slug instead. 'triage' offers windows11-21h2-x64 (plus ubuntu-22.04-amd64 and android-11-x64); the win10-style slug belongs to a different provider and does not apply here. Cassettes are deliberately NOT touched. vm_slug travels in the POST body and the VCR matcher is [method, scheme, host, port, path, query], so replay is unaffected — and hand-editing cassettes is against the recording convention. The old recorded bodies simply get refreshed the next time these cassettes are re-recorded delete-driven against a live stack. Verified: 13 sandbox/sample tests pass on replay.
|
Reviewed against AGENTS.md + Verified:
|
mjbradford89
approved these changes
Jul 30, 2026
This was referenced Aug 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The sandbox tests dispatched
'triage'withvm_slug='win10-build-15063'at 8 call sites. That isn't a valid triage VM — the server rewrites any slug containingwin10towindows11-21h2-x64for backward compatibility and logs an ERROR each time. So every live e2e run carried 8 self-inflicted server-side ERROR lines.'windows11-21h2-x64'(4 inclient_scan_test.py, 4 inasync_client_test.py).triageofferswindows11-21h2-x64,ubuntu-22.04-amd64,android-11-x64; thewin10-style slug belongs to a different provider.Cassettes are deliberately untouched
vm_slugtravels in the POST body, and the VCR matcher is[method, scheme, host, port, path, query]— the body isn't matched, so replay is unaffected. Hand-editing cassettes is also against the recording convention (they're produced by running against a live stack). The 8 cassettes that still carry the old recorded body will pick up the new slug naturally the next time they're re-recorded delete-driven.The server's response was already the rewritten one, so the recorded responses stay correct either way.
Verification
pytest test/client_scan_test.py test/async_client_test.py -k "sandbox or sample"→ 13 passed on replay.